New dropA new codebase every week — fresh repo, fresh bugsSee this week's

Add GET /v1/skus (list all SKUs) — feature ticket · 10xDebuggable

enhancementintermediateP3internal/handler/sku_handler.go, internal/handler/server.goLevel 2 · Implement a feature15 XP45–60 minutes

Add GET /v1/skus (list all SKUs)

Nobody has started this yet — be first.

Business impact

The API can fetch one SKU at a time by id (GET /v1/skus/{id}), but there is no way to discover what SKUs exist at all short of querying Postgres directly. An admin dashboard or a support engineer investigating "what's even in the catalog right now?" has nothing to call.

Problem

The route is already wired up (r.Get("/skus", s.ListSKUs)) and Server.ListSKUs exists only as a panicking TODO(ticket-14) stub.

Current behavior

GET /v1/skus currently returns a 500 because Server.ListSKUs panics with "TODO(ticket-14): Server.ListSKUs not implemented".

Expected behavior

GET /v1/skus returns a JSON array of every known SKU's current snapshot, in the same shape GET /v1/skus/{id} already returns for one.

Steps to reproduce

go test ./tickets/tests/... -run TestTicket14 -v
Observe: GET /v1/skus returns 500 -- Server.ListSKUs is still the panicking "TODO(ticket-14)" stub.

Why this matters

The route is already wired up (r.Get("/skus", s.ListSKUs) in internal/handler/server.go) and Server.ListSKUs exists as a stub -- this is purely about writing the query (SELECT ... FROM sku_inventory, no WHERE) and reusing the existing toSKUResponse conversion for each row, the same way GetSKU already does for one.

Suggested approach

Look at GetSKU right above ListSKUs in internal/handler/sku_handler.go for the query/scan pattern, and ListLedger further down for the "loop over rows.Next(), build a slice" pattern for returning more than one row.

Acceptance criteria

GET /v1/skus returns 200 with a JSON array containing every SKU currently in sku_inventory
Each array entry has the same fields GET /v1/skus/{id} returns
An empty catalog returns an empty array ([]), not null or an error
tickets/tests/ticket14_test.go passes

Verification

TEST_DATABASE_URL=postgresql://... go test ./tickets/tests/... -run TestTicket14 -v

Hints (0/2)

Try it without hints first — the reading is the exercise.

Working on this ticket

Work on a branch named for the ticket — that's what you'll submit.

Branch off your fork

$git checkout -b feat/list-skus-endpoint

Fix it and commit

Meet every acceptance criterion, and add a test that would have caught this.

Push the branch

$git push -u origin feat/list-skus-endpoint

Submit it below

Paste your fork URL and the branch name, with a short write-up of the root cause.

Submit your fix

Questions

Stuck on something?

Ask about anything unclear in the ticket — the maintainer and anyone who has solved it can answer. Please don't post full solutions.

No questions yet. If something in this ticket reads ambiguously, you are probably not the only one — ask.

The project

Inventory Reservation Service

Oversell-proof stock reservations under extreme concurrent contention: 100 units, 50,000 simultaneous "Buy Now" clicks, and exactly 100 must succeed.

Fork on GitHub

Download

Setup

Inventory Reservation Service

git clone <your-fork>
cd GolangDevTraining/inventory
docker compose up --build   # Postgres + 2 hot-reloading app replicas + Adminer

Two app replicas are on by default, not opt-in: the TTL reaper's claiming and the reservation hot path's atomicity guarantee only prove anything interesting with more than one process sharing the same Postgres and the same SKU row. App replica 1 is reachable at ; Postgres at . Seeded on startup: (10 units) and (5,000 units). Verify with and .

SKIP LOCKED

http://localhost:8081

localhost:5434

flash-sale

everyday-widget

curl localhost:8081/healthz

go run ./cmd/loadtest -url http://localhost:8081 -sku flash-sale -concurrency 10000

export TEST_DATABASE_URL=postgresql://inventory:inventory@localhost:5432/inventory_test?sslmode=disable
go test ./tickets/tests/... -run TestTicket24 -v   # a single ticket
./tickets/run_tickets.sh                           # all 25, clean pass/fail summary